Create a ResourceNode for a method within a class #90

Activity

1. fhessel commented on Jun 6, 2020

   

   fhessel

   on Jun 6, 2020

   Owner

   More actions

   Sorry it took so long to get back to this.

   That indeed wasn't possible by now, as you could only use classic function pointers with the ResourceNode constructor, which doesn't work with the outcome of an std::bind.

   I created PR #91 which should now allow to use both, being backward-compatible. That still needs a bit of testing before I can safely merge into the master branch, but maybe it helps you to proceed.

   This slightly modified version of your example should work with the PR:

   // Only if you use PlatformIO
   #include <Arduino.h>
   
   // Added WiFi for convenience
   #define WIFI_SSID "YourNetwork"
   #define WIFI_PSK "someverysecretpassword"
   #include <WiFi.h>
   
   #include <HTTPServer.hpp>
   #include <HTTPRequest.hpp>
   #include <HTTPResponse.hpp>
   #include <HTTPSCallbackFunction.hpp>
   
   using namespace httpsserver;
   
   class ConfigurationModule {
     public:
       void handleDisplayConfig(HTTPRequest *req, HTTPResponse *res) {
         // Added some output to see it's actually working
         res->setHeader("Content-Type", "text/plain");
         res->println("handleDisplayConfig()");
       }
   
       void init(HTTPServer &server) {
           // Important: Use "&server" instead of "server". Passing the server by value will neither work
           // nor be what you intended to do here (you want the same server to modify it, not a copy).
   
           // HTTPSCallbackFunction is now an std::function, so you can assign the result of a bind
           HTTPSCallbackFunction handler =
             std::bind(&ConfigurationModule::handleDisplayConfig, this, std::placeholders::_1, std::placeholders::_2);
           // Note that you will not be able to retrieve that node anymore if you create it "on the fly" here.
           // I assume that's for the sake of an example, but if you wanted to tear down the application,
           // you would need to store a pointer to that ResourceNode anywhere in this class and clean it
           // up in the destructor.
           server.registerNode(new ResourceNode("/configure", "GET", handler));
       }
   };
   
   ConfigurationModule config = ConfigurationModule();
   HTTPServer webserver = HTTPServer();
   
   void handler1(HTTPRequest *req, HTTPResponse *res) {
       // Also added some text here for testing
       res->setHeader("Content-Type", "text/plain");
       res->println("handler1()");
   }
   
   void handler2(HTTPRequest *req, HTTPResponse *res) {
       res->setHeader("Content-Type", "text/plain");
       res->println("handler2()");
   }
   
   void setup() {
       Serial.begin(115200);
       // Connect to WiFi
       Serial.println("Setting up WiFi");
       WiFi.begin(WIFI_SSID, WIFI_PSK);
       while (WiFi.status() != WL_CONNECTED) {
         Serial.print(".");
         delay(500);
       }
       Serial.print("Connected. IP=");
       Serial.println(WiFi.localIP());
   
       webserver.registerNode(new ResourceNode("/htmlResponse", "GET", handler1));
       webserver.registerNode(new ResourceNode("/jsonResponse", "GET", handler2));
       config.init(webserver);
       webserver.start();
   }
   
   void loop() {
       webserver.loop();
   }

   I hope it's not too late for you, however, that issue has been on my todo list for some time now anyway. It would be nice if you could give me feedback in either case.
2. fhessel

   added

   feature

   on Jun 6, 2020
3. Thomas-Blondeau commented on Jun 24, 2020

   

   Thomas-Blondeau

   on Jun 24, 2020

   More actions

   Hello !

   I got the same issue this week and I am happy to read that you just prepared a PR. Is it possible to use the fix right now ? Maybe if I pull the branch ?

   Thank you !
4. fhessel commented on Jun 24, 2020

   

   fhessel

   on Jun 24, 2020

   Owner

   More actions

   Hi,

   you can clone the repository and switch to the feature branch:

   git clone https://github.com/fhessel/esp32_https_server.git
   git checkout origin/feature/functional-callbacks

   If you're using Platform IO, do it in your project's lib folder, if you use the Arduino IDE, do it in the libraries folder in your Sketchbook.

   It would be great if you could tell me if that works for you, or if you run into problems. If it works, I'd merge the PR soon.
5. Thomas-Blondeau commented on Jun 24, 2020

   

   Thomas-Blondeau

   on Jun 24, 2020

   More actions

   I will clone the branch tonight and test it. I use Visual code with the Arduino Plugin.

   I'll give you my feedbacks very soon.
6. surfsoft commented on Oct 13, 2020

   

   surfsoft

   on Oct 13, 2020

   Author

   More actions

   Apologies for my much delayed response, I hope to get back to this in the next week or two...