Repository navigation
More steam frame battery/charging state fixes - #2175
Open
matte-schwartz wants to merge 2 commits into
Open
matte-schwartz wants to merge 2 commits into
matte-schwartz wants to merge 2 commits into
Conversation
The max1720x fuel gauge only knows its own SOC and average current, so while the charger holds the battery near full on AC its status flaps between Charging, Not charging and Discharging every few seconds, and the HUD flips between the plug icon and ~20W with a 28h estimate. deckardcharger publishes the combined status, so prefer it like we do for battery_percent.
"Not charging" means external power is present but the battery isn't being charged, e.g. held at a charge limit, so showing a discharge rate and remaining time there is wrong. Idle batteries report it too, as the second battery on dual-battery laptops does while the first discharges, along with Full. So rather than returning 0 as soon as any battery isn't discharging, sum only the discharging ones and show the plug when none are.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.