Skip to content

[v3] Auth Module: Bring methods in-line & add missing methods #118

Closed

Description

@Ehesp

Currently working through the auth docs on my own fork, there's some differences between the Firestack methods vs the JS method names. I believe it should mimic the Firebase API as close as possible, since most users will reference their docs on how to do certain things, it'd make it easy to come straight to the same method here.

Also some methods are missing:

Differences:

Missing:

Not working

  • signOut
    • Returns ok but doesn't sign out.
  • signIn with disabled account(all?)
    • Crashes the app on boot.

Activity

  1. auser commented on Nov 8, 2016

    @auser
    Contributor

    At this point, I think we need to create a deprecated helper that logs out deprecated warnings about using these methods and rename the methods to match their firebase js counterparts. Want to take a crack at that?

  2. Ehesp commented on Nov 8, 2016

    @Ehesp
    ContributorAuthor

    Sure, would a console.warn suffice?

  3. auser commented on Nov 9, 2016

    @auser
    Contributor

    Yep, definitely would.

  4. changed the title [-]Auth Module: Bring methods in-line & add missing methods[/-] [+][v3] Auth Module: Bring methods in-line & add missing methods[/+] on Nov 19, 2016
  5. added this to the v3 milestone on Nov 19, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions