Skip to content

Keep collapsed sidebar status glyphs consistent with their rows - #5811

Open
brsbl wants to merge 3 commits into
mainfrom
bb/fix-sidebar-rollup-in-collapsed-sections-thr_riatcyp349
Open

brsbl wants to merge 3 commits into
mainfrom
bb/fix-sidebar-rollup-in-collapsed-sections-thr_riatcyp349

Conversation

@brsbl

@brsbl brsbl commented Oct 20, 2026 •

Copy link
Copy Markdown
Collaborator

Human comments

What was wrong

Collapsed sections combined one thread's draft with another's runtime and plugin status, exposing a question that no row showed. Collapsed parents also omitted their hidden children's plugin statuses. See #5810.

What changed

  • Collapsed parents inherit hidden-child plugin status through the existing row precedence.
  • Section summaries choose among each thread's resolved glyph instead of combining unrelated activity flags.

How you verified

  • Both regressions failed against main in remote CI.
  • All 455 thread-list tests passed on the fix in remote CI.
  • Remote CI is green on 72e2fa6208d15f50ad947d078d358abf96bc696e.
  • Full five-panel Slop Cop passed with no P0/P1 issues; two P2 follow-ups are recorded below.
  • Isolated Chrome for Testing e2e passed on the exact head at 1440×900 and 390×844: hidden child questions, runtime plus an unrelated draft, and a single idle waiting thread; collapse/expand, reload persistence, and status stability across plugin polls. No browser console errors were recorded.
  • The isolated server used a fresh empty data directory inside the worktree and synthetic fixtures, with unchanged Inline Decisions 0.3.3 and Thread Organizer 0.1.14.
Slop Cop follow-ups (P2)
  • Resolve hidden-child plugin visibility before parent inheritance, so a parent or sibling draft cannot expose a running child's question. Source. Done when both draft placements keep the question hidden while idle-child questions still roll up.
  • Reuse the existing shared draft-ID snapshot for section summaries, avoiding one full-sidebar draft subscription store per group. Source. Done when section count does not multiply per-thread draft subscriptions and individual drafts still update summaries.

These are validated source-review findings; no benchmark or separate runtime reproduction is claimed. Kept as follow-ups under the requested P0/P1-only repair policy.

Before and after

Before: 7e4232ef241b5cdfb7d272cee044fe6f82702c70 (main) · After: 72e2fa6208d15f50ad947d078d358abf96bc696e · Captured at 2×

Screen / state Viewport Before After
A: hidden child, parent collapsed Desktop · 1440×900 Before A, nested child; desktop, section open and parent collapsed, desktop After A, nested child; desktop, section open and parent collapsed, desktop
A: hidden child, parent collapsed Mobile · 390×844 Before A, nested child; mobile, section open and parent collapsed, mobile After A, nested child; mobile, section open and parent collapsed, mobile
B: running thread + unrelated draft, section collapsed Desktop · 1440×900 Before B, runtime plus unrelated draft; desktop, section collapsed, desktop After B, runtime plus unrelated draft; desktop, section collapsed, desktop
B: running thread + unrelated draft, section collapsed Mobile · 390×844 Before B, runtime plus unrelated draft; mobile, section collapsed, mobile After B, runtime plus unrelated draft; mobile, section collapsed, mobile

Fixes #5810

BB-Thread-ID: thr_riatcyp349

AGENT GENERATED

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ⚠️ Failed 2026-10-20T00:47:47.949690Z d2a3232 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@chatgpt-codex-connector

Copy link
Copy Markdown

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.
To continue using code reviews, add credits to your account and enable them for code reviews in your settings.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Collapsed sidebar sections show questions missing from their visible rows

1 participant