Repository navigation
fix(acp): keep calendar-version identifiers in ACP maintenance - #5814
Open
SawyerHood wants to merge 1 commit into
Open
SawyerHood wants to merge 1 commit into
SawyerHood wants to merge 1 commit into
Conversation
Ports the surviving half of #5694 to the ACP bridge that replaced the original in #5775 (its other half patched the deleted bridge). ACP maintenance read installed and health versions with the shared strict SemVer reader, so calendar versions with zero-padded month/day components (cursor-agent's `2026.08.11-e8db854`) were discarded even though the executable was found (#5693). The bridge now accepts complete calendar tokens locally for those probes; ordinary SemVer parsing, the shared parser and latest-version availability are unchanged. Three calendar-version cases fail without the fix; the nine controls pass either way. Fixes #5693 Co-authored-by: bb-slop-cop[bot] <316425484+bb-slop-cop[bot]@users.noreply.github.com>
SawyerHood
added this pull request to stack #5818
October 20, 2026 00:50
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Human comments
What was wrong
ACP maintenance read installed and health versions with the shared strict SemVer reader. Calendar versions with zero-padded month/day components, such as cursor-agent's
2026.08.11-e8db854, were discarded even though the executable was found (#5693). #5694 fixed both bridges; #5775 then deleted the original, so only its rebuilt-bridge half still applies.What changed
Ports the surviving half of #5694 by @bb-slop-cop, at the bridge's new path:
packages/provider-bridge-acp/src/bridge/provider-maintenance.tsnow accepts complete calendar-version tokens locally for installed and health versions.How you verified
pnpm exec turbo run test lint typecheck --filter=@bb/provider-bridge-acp: 522 passed, 4 skipped./api/v1/system/providers/statenow reportsinstalledVersion: "2026.08.11-e8db854"for acp-cursor.Fixes #5693. Supersedes #5694.