Repository navigation
fix(acp): spell out every bb skill chip the agent did not advertise - #5815
Open
SawyerHood wants to merge 1 commit into
Open
SawyerHood wants to merge 1 commit into
SawyerHood wants to merge 1 commit into
Conversation
A bb skill chip reaches an ACP agent as literal `/name` text. OpenCode reads a leading `/name` as one of its own commands and ends the turn without calling the model (#4923). The rebuilt bridge rewrote only a chip at the very start of the first text item, and only once the agent had advertised its commands, so a chip on the first turn, in the middle of a message, in a later text item, or next to an advertised command still went through raw. The bridge now rewrites every slash chip whose name is a configured bb skill (skills/configure roots) to `Use the bb skill "name"` (with a colon when it leads further text), in every text item, right to left, skipping overlapping or mismatched ranges. It leaves the agent's own advertised commands, chips that are not bb skills, and unmarked slash text alone. This follows the approach of #5055 by @timurkhakhalev, rebuilt on the new bridge. Fixes #4923 Co-authored-by: Timur Khakhalev <timurkhakhalev@users.noreply.github.com>
SawyerHood
added this pull request to stack #5818
October 20, 2026 00:50
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Human comments
What was wrong
A bb skill chip reaches an ACP agent as literal
/nametext. OpenCode reads a leading/nameas one of its own commands and ends the turn without calling the model (#4923).The rebuilt bridge rewrote a chip only in narrow cases:
A chip on the first turn, mid-message, in a later text item, or next to an advertised command still went through raw.
What changed
textWithBbSkillCommandsSpelledOut(bridge.ts) replacestextWithoutUnknownLeadingSkillCommand:skills/configureroots), in every text item.Use the bb skill "name", with a trailing colon when the chip leads further text. Chips are processed right to left, skipping overlapping or mismatched ranges.This follows #5055 by @timurkhakhalev (credited as co-author), rebuilt on the new bridge.
How you verified
pnpm exec turbo run test lint typecheck --filter=@bb/provider-bridge-acp --filter=@bb/provider-parity: bridge 522 passed, parity 59 passed.Fixes #4923. Supersedes #5055.