Repository navigation
Conversation
…acing The new `cloudflare-workers-without-tracing-send-to-sentry` app deploys a real Worker with `tracesSampleRate: 0` and Cloudflare traces on. Its test checks that an error in Sentry has the trace id of the Cloudflare trace and the Cloudflare request span as its parent. The test finds the Cloudflare request span in Workers Logs by the `cf-ray` of the request, with the new `fetchWorkersLogsEvents` helper. The query endpoint needs a `CLOUDFLARE_API_TOKEN` with "Workers Observability: Edit". Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Contributor
size-limit report 📦Compared: 62fc0aa (PR test merge using jp/cloudflare-native-trace-id-events at 0ac234a) Against: 8042719 (jp/cloudflare-native-trace-id-events) · base run #63102
|
Contributor
Optional E2E testsSome optional checks were not successful. They do not block the merge. 1 failing, 64 successful. See the run.
Successful checks
|
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds the e2e app
cloudflare-workers-without-tracing-send-to-sentry. It deploys a real Worker withtracesSampleRate: 0and Cloudflare traces on, and checks that an error in Sentry has the Cloudflare trace id and the Cloudflare request span as its parent. More tests without tracing can go into this app.Why
The integration tests of #25613 run on a local workerd. This test checks the fix on Cloudflare, against the span that Workers Observability stores for the request.
Sentry traces
With #25613, the error is in the Cloudflare trace: https://sentry-sdks.sentry.io/explore/traces/trace/666e09b1979b18724b8fd77faed99e1b/?project=4510555608449024&statsPeriod=14d
Without #25613, the error has its own trace: https://sentry-sdks.sentry.io/explore/traces/trace/bc56b593dcf941c7b21af6216f215dff/?project=4510555608449024&statsPeriod=14d