Skip to content

feat(profiling): chunk rotation - #2270

Open
Litarnus wants to merge 1 commit into
continuous-profiling-08-manual-profiler-apifrom
continuous-profiling-09-chunk-rotation
Open

Litarnus wants to merge 1 commit into
continuous-profiling-08-manual-profiler-apifrom
continuous-profiling-09-chunk-rotation

Conversation

@Litarnus

Copy link
Copy Markdown
Collaborator

Registers a flush callback on excimer and buffers them. There is one limitation of excimer, which is that it might not produce enough samples if blocking operations are involved. So getting 6060 samples (60s x 101hz) might actually be more than 60s. When adding it to the buffer, we will check if the timestamp is within bounds, and if not, it will flush out parts of the samples to not go over the duration.

@Litarnus
Litarnus added this pull request to stack #2262 October 16, 2026 14:02

@cursor cursor Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

Want reviews to match your repository better? Bugbot Learning can learn team-specific rules from PR activity. A team admin can enable Learning in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit 11af492. Configure here.

Comment thread src/Profiling/ContinuousProfiler.php Outdated
@Litarnus
Litarnus removed this pull request from stack #2262 October 17, 2026 23:14
@Litarnus
Litarnus added this pull request to stack #2282 October 17, 2026 23:16
@Litarnus
Litarnus force-pushed the continuous-profiling-09-chunk-rotation branch from 11af492 to 1f21749 Compare October 18, 2026 10:45
@Litarnus
Litarnus force-pushed the continuous-profiling-09-chunk-rotation branch from 1f21749 to be540b4 Compare October 18, 2026 19:19
@Litarnus
Litarnus force-pushed the continuous-profiling-09-chunk-rotation branch from be540b4 to 9915b1e Compare October 18, 2026 19:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant