listBranches() does not return all branches in a repository #592

Activity

1. timgcarlson commented on Oct 3, 2019

   

   timgcarlson

   on Oct 3, 2019

   Last edited by timgcarlson

   Author

   More actions

   I'm able to get all the branches if I use _requestAllPages and __fullname:

   let repo = githubApi.getRepo(user, repo)
   repo._requestAllPages(`/repos/${this._repo.__fullname}/branches`, { AcceptHeader: 'inertia-preview' })
       .then(response => console.log('all branches:', response.data));
   

   Is this going to be my only solution without updating this wrapper? I'm happy to submit a PR if this is a feature that could be added. Perhaps including an option to use _requestAllPages when needed, but defaulting to not use it to avoid rate limits.
2. j-rewerts commented on Oct 8, 2019

   

   j-rewerts

   on Oct 8, 2019

   Member

   More actions

   This is related to a larger issue around paging. We have quite a few issues for paging, but I'd like to leave this open to ensure it gets dealt with. See #578.
3. j-rewerts commented on Oct 8, 2019

   

   j-rewerts

   on Oct 8, 2019

   Member

   More actions

   PRs are welcome, btw! Also, discussion around how we're going to handle paging would be welcome. Comment in #578 if you're interested.