Repository navigation
Conversation
hvitved
force-pushed
the
unified/type-inference-nested-types
branch
from
October 21, 2026 13:57
2c69161 to
b14b51a
Compare
hvitved
force-pushed
the
unified/type-inference-nested-types
branch
6 times, most recently
from
October 22, 2026 09:30
03284cb to
0455baf
Compare
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
Implicit argument handling and parent-scope checks still produce incorrect or incomplete nested-type inference.
2 open issues
What changed in this PR
Extends Unified’s type inference to represent nested types and preserve their enclosing generic arguments, with Swift regression coverage.
Changes:
- Adds parent-type parameters and qualified type names.
- Updates type mentions and enum construction to propagate parent-type paths.
- Adds nested-type tests and updates inference expectations.
| File | Description |
|---|---|
unified/ql/test/library-tests/type-inference/type-inference.expected |
Updates expected inference results. |
unified/ql/test/library-tests/type-inference/nested_types.swift |
Adds nested-generic, self-type, and extension coverage. |
unified/ql/test/library-tests/type-inference/generics.swift |
Removes a resolved MISSING annotation. |
unified/ql/test/library-tests/type-inference/classes.swift |
Updates the inline expected nested-type name. |
unified/ql/lib/codeql/unified/internal/typeinference/TypeMention.qll |
Adds nested-type qualification and implicit argument handling. |
unified/ql/lib/codeql/unified/internal/typeinference/TypeInferencePluginSwift.qll |
Removes Swift-specific enum plugin hooks. |
unified/ql/lib/codeql/unified/internal/typeinference/TypeInferencePlugin.qll |
Removes enum-specific hooks and wrappers. |
unified/ql/lib/codeql/unified/internal/typeinference/TypeInference.qll |
Integrates parent paths into constructor inference. |
unified/ql/lib/codeql/unified/internal/typeinference/Type.qll |
Introduces parent-type parameters and qualified names. |
unified/ql/lib/codeql/unified/internal/AstExtra.qll |
Adds shared enum relationships and enum-field modeling. |
Review effort: Max
hvitved
force-pushed
the
unified/type-inference-nested-types
branch
from
October 22, 2026 13:31
0455baf to
e55b569
Compare
Comment on lines
+149
to
+152
| this = | ||
| any(MemberAccessExpr mae | | ||
| exists(TypePath suffix | | ||
| result = mae.getBase().(TypeMention).getTypeAt(suffix) and |
Comment on lines
+731
to
+732
| tp = receiverType.getATypeParameter() and | ||
| path0 = TypePath::singleton(tp) |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.