Repository navigation
ci: reduce SDK CI critical paths and runner saturation - #2480
Merged
Merged
Conversation
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
Restore Java site-artifact publication and address or document the consistency-review model pin.
Once you've addressed the issues Copilot identified, you can request another Copilot review.
Review tier: Balanced
Findings: 2
New issues introduced by this change (2)
| Severity | Finding |
|---|---|
.github/workflows/java-sdk-tests.yml — Removing the push trigger makes the Upload test results for site generation step at lines… |
|
.github/workflows/sdk-consistency-review.md — This unrelated frontmatter change hard-codes both the review model and the threat-detection model… |
What changed in this PR
Reduces SDK CI latency and runner saturation while preserving merge-queue validation.
Changes:
- Cancels superseded runs, removes redundant
mainmatrices, and adds timeouts. - Optimizes .NET, Java, Rust, and Go execution.
- Updates the SDK consistency reviewer model.
| File | Review |
|---|---|
java/sdk/pom.xml |
Excludes duplicated subprocess tests from in-process cells. |
go/internal/e2e/rpc_server_e2e_test.go |
Initializes the replay proxy earlier. |
.github/workflows/sdk-consistency-review.md |
Model pin bypasses repository-level overrides; remove or document it. |
.github/workflows/sdk-consistency-review.lock.yml |
Regenerates the compiled workflow. |
.github/workflows/rust-sdk-tests.yml |
Parallelizes quality jobs and adds timeouts. |
.github/workflows/required-checks.yml |
Cancels superseded PR runs. |
.github/workflows/python-sdk-tests.yml |
Removes main runs and adds a timeout. |
.github/workflows/nodejs-sdk-tests.yml |
Removes redundant main runs. |
.github/workflows/java-sdk-tests.yml |
Site test-result publication becomes unreachable in normal automation. |
.github/workflows/go-sdk-tests.yml |
Removes main runs and adds a timeout. |
.github/workflows/dotnet-sdk-tests.yml |
Optimizes validation and shards; the format failure branch cannot emit its intended diagnostic. |
Suppressed comments (1)
.github/workflows/dotnet-sdk-tests.yml:38
- GitHub Actions invokes
shell: bashwith-e, so whendotnet formatfails the step exits immediately and never reaches this custom diagnostic branch. Wrap the command directly in theifcondition so contributors receive the intended remediation message.
dotnet format --no-restore --verify-no-changes
if [ $? -ne 0 ]; then
echo "❌ dotnet format produced changes. Please run 'dotnet format' in dotnet"
exit 1
fi
💡 Configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Summary
mainafter the same tree passed merge-queue validation, avoiding about 293 runner-minutes per mergeInvestigation
Recent full merge-group runs normally complete in about 11:35–13:07. The 35–65 minute outliers combined two problems: individual legs waited as long as 54 minutes for runners, and occasional test legs hung for 35–48 minutes. A full run creates roughly 48 substantive jobs and consumes 280–300 runner-minutes, so redundant and superseded matrices amplify queue pressure.
Measured normal critical-path legs were .NET Windows shard 2 (~12:01), Go Windows default (~10:19), Rust Ubuntu default (~10:10), Java Windows ARM64 in-process (~9:32), and Python Windows in-process (~9:16).
Changes and expected impact
Because these jobs run concurrently, the reductions are not additive. The expected normal all-language wall time is roughly 9–10 minutes instead of about 12 minutes, while the concurrency and post-merge changes reduce queue pressure much more substantially.
Coverage and validation
main, so normal queued commits still show their green/red SDK status without a redundant rerun.mainno longer start standalone SDK matrices.