Repository navigation
Bump minimum VS Code version to 1.101.0 - #4619
Merged
Merged
Conversation
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
🔵 Needs a closer look
The support cutoff bypasses the documented advance-warning release and needs maintainer review of the compatibility impact.
1 open issue
1 file not reviewed
extensions/ql-vscode/package-lock.json: Generated file
What changed in this PR
Raises the CodeQL extension’s minimum supported VS Code version from 1.90.0 to 1.101.0 to target an editor runtime with Node 22.
Changes:
- Update the activation warning threshold and declared VS Code requirement.
- Align VS Code API typings and lockfile entries with 1.101.0.
- Refresh Chromium/Electron build targets and document the compatibility change.
| File | Description |
|---|---|
extensions/ql-vscode/src/extension.ts |
Raise the minimum-version warning threshold. |
extensions/ql-vscode/package.json |
Update the VS Code requirement and API typings. |
extensions/ql-vscode/package-lock.json |
Synchronize engine and dependency metadata. |
extensions/ql-vscode/gulpfile.ts/chromium-version.json |
Target Chromium 134 and Electron 35.5.1. |
extensions/ql-vscode/CHANGELOG.md |
Announce the increased VS Code requirement. |
Review effort: Max
cklin
approved these changes
Oct 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bump the minimum supported VS Code version from
1.90.0to1.101.0(which ships with Node 22) as discussed in the foundation team meeting. The reason for the bump is to be able to remove dependencies (specificallyglob) by functionality in Node 22.I haven't bothered with the two-step process of first warning that the version will be unsupported, given how old it is.
MIN_VERSIONand its comment inextensions/ql-vscode/src/extension.tsengines.vscodeand@types/vscodeinextensions/ql-vscode/package.jsonandextensions/ql-vscode/package-lock.jsonextensions/ql-vscode/gulpfile.ts/chromium-version.jsonfor VS Code1.101.0(Chromium 134 / Electron 35.5.1)