Repository navigation
feat(app): rebuild Settings and top-anchor every dialog - #171
Merged
Merged
Conversation
Contributor
Author
|
Rename evidence re-measured with an explicit navigation to candidate host 127.0.0.1:4197 (origin asserted), Channels page sidebar RowMenu → Rename channel: top 180, width 320, focus in "Channel name" with full selection [0,13]; Escape closes and returns focus to the rename-target row. Tested head b11535a. CommandPalette has no apps/app consumer, so it has no product route to exercise; its change is source/CSS-reviewed only. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #170.
Dialogs were vertically centered, so Settings jumped whenever late-loading content or a section switch changed its height. Every dialog now sits at a fixed top position. Settings is rebuilt as a fixed two-column shell.
Shared dialog geometry (
packages/ui/src/ui/dialog.tsx)clamp(1rem, 40dvh - 8rem, 20dvh).--dialog-maxis the room left below it. Generic dialogs, Settings and CommandPalette all size from it, which replaces the palette's inline100vhsizing.w/max-wutilities. twMerge couldn't overridesm:max-inline-sm, so Settings and the palette were stuck at 24rem.motion-safe.Settings
ace:updates.Validation (local evidence on natembp:
/tmp/ace-ui-refresh-20261006/settings-evidence)5194bf7), while loading and switching sectionsb11535a)bun types,bun run ci, the app build and CI pass. React Doctor scores 90/100; its warnings are the existing icon-export pattern and Settings complexity.Not exercised: the managed helper's start/stop/restart and approval states (source builds never attach a helper, and Canary's was left alone); update available/download/error states (dev build); the permission "Enable…" prompts (everything was already granted); and CommandPalette, which has no
apps/appconsumer and is reviewed in source and CSS only. Tab focus briefly escaping a modal happens on5194bf7too; it is tracked in #172.Built in Ace
Built in an Ace channel. Root Codex coordinated and did read-only review outside Ace (#9).
Gaps:
bun desktop devhost, withscreencapturefor captures.desktop_focustimed out,desktop_menurefused the Ace process,desktop_keyhas no comma key, and the Troubleshooting disclosure click failed.