Repository navigation
native2: build and release without Peekaboo; ship native2 in the package (#171) - #180
Merged
Merged
Conversation
…age (#171) Why: native2/Package.swift | npm ships native2/Sources without Tests, and SwiftPM refuses a test target whose folder is missing, so test targets exist only when Tests/ does Why: native2/Sources/desktop-tools-app/app.swift | a copy of native/sources/app/app.swift, not a symlink: npm pack drops symlinks; scripts.test.mjs keeps the copies identical until native/ goes
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #171. Part of the cutover (#143), step 7.
filesaddsnative2/Package.swiftandnative2/Sources. native2's test targets exist only whenTests/does, since the package ships without it.desktop-tools-build --native2: builds only native2, in<scratch>/native2, and writes the dylib, client, MCP server and app with notices for this package alone. It removes Peekaboo's and the pins' notices that a native/ build left behind.desktop-tools-appfrom a copy ofnative/sources/app; npm pack drops symlinks, so it's a copy. A test keeps the copies identical, andcanImportpicks each package's callers module.release.ymltakes astackinput,native2by default,nativeto switch back, andscripts/release.tsreads it asDT_STACK.--native2together withcreateDesktop({ wire: 2 }).Checked:
npm pack, unpacked into a clean folder, builds with--native2and produces the dylib, client, mcp, app andLicenses/desktop-tools. Nothing is fetched and native/ isn't built.npm run dev-app -- --native2now runs native2's own app shell. Its client and bundled MCP both serve calls.The README, the
dist/mcp.jsshim and the release itself come next, in a separate PR.