universal_newlines is not respected if git process times out #1116

Activity

1. Byron

   added

   waiting for feedback

   on Jan 28, 2021
2. Byron commented on Jan 28, 2021

   

   Byron

   on Jan 28, 2021

   Member

   More actions

   Can you be more specific as to allow a PR to be created? In that moment I request a change of the subject as well.
   This issue isn't currently actionable.

   This issue will be reopened once the requested information was provided.
3. Byron

   closed this as completedon Jan 28, 2021
4. x-santiaga-x commented on Jan 28, 2021

   

   x-santiaga-x

   on Jan 28, 2021

   ContributorAuthor

   More actions

   If we run operation long enough to be killed after timeout and use universal_newlines set to True as this

   from git.cmd import Git
   g = Git(r'/path/to/repo')
   g.rev_list('HEAD', kill_after_timeout=1e-6, universal_newlines=True)
   

   script execution stopped with traceback

   Traceback (most recent call last):
     File "../src/test.py", line 28, in <module>
       g.rev_list('HEAD', kill_after_timeout=1e-6, universal_newlines=True)
     File "/venv/path/lib64/python3.6/site-packages/git/cmd.py", line 542, in <lambda>
       return lambda *args, **kwargs: self._call_process(name, *args, **kwargs)
     File "/venv/path/lib64/python3.6/site-packages/git/cmd.py", line 1006, in _call_process
       return self.execute(call, **exec_kwargs)
     File "/venv/path/lib64/python3.6/site-packages/git/cmd.py", line 789, in execute
       if stderr_value.endswith(newline):
   TypeError: endswith first arg must be bytes or a tuple of bytes, not str
   

   because stderr_value is an error message about timeout decoded to bytes, but with universal_newlines = True newline is str, not bytes.
5. Byron

   added

   acknowledged

   help wanted

   and removed

   waiting for feedback

   on Jan 28, 2021
6. Byron

   reopened this on Jan 28, 2021
7. Byron

   changed the title [-]Yet another universal_newlines TypeError[/-] [+]`universal_newlines` is not respected if git process times out[/+] on Jan 28, 2021
8. Byron commented on Jan 28, 2021

   

   Byron

   on Jan 28, 2021

   Member

   More actions

   Thanks a lot! This looks like the logic here needs to adhere to the universal newlines flag. Would you be able to submit a PR for a fix?
9. Byron

   closed this as completedin 3c19a6eon Jan 28, 2021
10. Byron

    added this to the v3.1.13 - Bugfixes milestone on Jan 28, 2021
11. Shidfar

    added a commit that references this issue on Apr 28, 2025

    fix universal_newlines TypeError

    ...

    This issue will close once commit 3c19a6e is merged into the 'master' branch.

    3c19a6e