Found a problem with the args of the Dictionary "items" function.

Current Results
in gpython

>>>> d_list = {'a' : 1, 'b' : 2}
>>>> for k, v in d_list.items("hi"):
>>>>     print(k,':',v)
a : 1
b : 2

in python

>>>> d_list = {'a' : 1, 'b' : 2}
>>>> for k, v in d_list.items("hi"):
>>>>     print(k,':',v)
Traceback (most recent call last):
  File "test.py", line 2, in <module>
    for k, v in d_list.items("hi"):
TypeError: items() takes no arguments (1 given)

gpython/py/dict.go

Lines 30 to 39 in af17d7d

    
           func init() { 
        
           	StringDictType.Dict["items"] = MustNewMethod("items", func(self Object, args Tuple) (Object, error) { 
        
           		sMap := self.(StringDict) 
        
           		o := make([]Object, 0, len(sMap)) 
        
           		for k, v := range sMap { 
        
           			o = append(o, Tuple{String(k), v}) 
        
           		} 
        
           		return NewIterator(o), nil 
        
           	}, 0, "items() -> list of D's (key, value) pairs, as 2-tuples") 
        
           }

I think we should add an error to this part of the code.

@Tim-St

@Tim-St
I found a mistake in the code I used in the issue.
Please check again.

@Tim-St

@Tim-St
Ok.
When I finish my ongoing Pull Request, I'll do this right away.

Fix bug in "items" function (#115)

Navigation Menu

Repository navigation

Found a problem with the args of the Dictionary "items" function. #101

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

	func init() {
	StringDictType.Dict["items"] = MustNewMethod("items", func(self Object, args Tuple) (Object, error) {
	sMap := self.(StringDict)
	o := make([]Object, 0, len(sMap))
	for k, v := range sMap {
	o = append(o, Tuple{String(k), v})
	}
	return NewIterator(o), nil
	}, 0, "items() -> list of D's (key, value) pairs, as 2-tuples")
	}

Found a problem with the args of the Dictionary "items" function. #101

Description

Activity

Sungmin-Joo commented on Sep 29, 2019

Sungmin-Joo commented on Oct 1, 2019

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions