Skip to content

Dict.__ne__ doesn't return NotImplemented  #108

Closed
#109
Closed
Dict.__ne__ doesn't return NotImplemented #108
#109

Description

@HyeockJinKim
HyeockJinKim
opened on Sep 30, 2019

Dict.ne doesn't return NotImplemented.

gpython/py/dict.go

Lines 167 to 176 in af17d7d

func (a StringDict) M__ne__(other Object) (Object, error) {
res, err := a.M__eq__(other)
if err != nil {
return nil, err
}
if res == True {
return False, nil
}
return True, nil
}

If result of __eq__ is Not Implemented, __ne__ should return NotImplemented, not True

Expected result (python)

>>> a = {}
>>> a.__ne__(3)
NotImplemented

Actual result (gpython)

>>> a = {}
>>> a.__ne__(3)
True

Activity

  1. HyeockJinKim
    added a commit that references this issue on Sep 30, 2019

    __ne__ of dict return NotImplemented

    9b364b3
  2. ncw
    closed this as completedin #109on Oct 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions