Skip to content

fix typos in tools/ and tests/ - #243

Merged
Jacksunwei merged 6 commits into
google:mainfrom
trandangtrungduc:fix_typos
Apr 18, 2025
Merged

Jacksunwei merged 6 commits into
google:mainfrom
trandangtrungduc:fix_typos

Conversation

@trandangtrungduc

Copy link
Copy Markdown
Contributor

fix minor typos in src/google/adk/tests/integration

def test_crewai_tool_success(agent_runner: TestRunner):
  _call_function_and_assert(
      agent_runner,
      "direcotry_read_tool",  # Typo: should be "directory_read_tool"
      "Find all the file paths",
      "file",
  )

and in src/google/adk/tools/openapi_tool/openapi_spec_parser

def _load_spec(
    self, spec_str: str, spec_type: Literal["json", "yaml"]
) -> Dict[str, Any]:
  """Loads the OpenAPI spec string into adictionary."""  # Typo: should be "a dictionary"

@hangfei

hangfei commented Apr 18, 2025

Copy link
Copy Markdown
Collaborator

Could you resolve the conflicts?

@trandangtrungduc

Copy link
Copy Markdown
Contributor Author

Could you resolve the conflicts?

Yes, I have resolved it.

@Jacksunwei Jacksunwei added the ready to pull [Status] This PR is ready to be imported back to Google label Apr 18, 2025
copybara-service Bot pushed a commit that referenced this pull request Apr 18, 2025
COPYBARA_INTEGRATE_REVIEW=#243 from trandangtrungduc:fix_typos 6e317d6
PiperOrigin-RevId: 749106557
@Jacksunwei
Jacksunwei merged commit 5eca821 into google:main Apr 18, 2025
coder-aditi pushed a commit to coder-aditi/adk-python that referenced this pull request Jul 2, 2025
COPYBARA_INTEGRATE_REVIEW=google#243 from trandangtrungduc:fix_typos 6e317d6
PiperOrigin-RevId: 749106557
coder-aditi pushed a commit to coder-aditi/adk-python that referenced this pull request Jul 2, 2025
FrigaZzz pushed a commit to FrigaZzz/adk-python that referenced this pull request Aug 11, 2026
COPYBARA_INTEGRATE_REVIEW=google#243 from trandangtrungduc:fix_typos 6e317d6
PiperOrigin-RevId: 749106557
FrigaZzz pushed a commit to FrigaZzz/adk-python that referenced this pull request Aug 11, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready to pull [Status] This PR is ready to be imported back to Google

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants