Repository navigation
Conversation
…cies `google.adk.telemetry.google_cloud` exports traces, metrics, and logs to Google Cloud Telemetry (`telemetry.googleapis.com`) using the standard OTLP HTTP exporters (`opentelemetry-exporter-otlp-proto-http`) and `opentelemetry-resourcedetector-gcp`. The legacy `opentelemetry-exporter-gcp-logging`, `opentelemetry-exporter-gcp-monitoring`, and `opentelemetry-exporter-gcp-trace` packages are no longer imported in `google.adk.telemetry` and unnecessarily constrain dependency resolution (including a pre-release upper bound on `opentelemetry-exporter-gcp-logging`). Remove them from the `all`, `gcp`, and `test` extras in `pyproject.toml` and regenerate `constraints-3.11.txt` through `constraints-3.15.txt`.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Link to Issue or Description of Change
1. Link to an existing issue (if applicable):
2. Or, if no issue exists, describe the change:
Problem:
pyproject.tomlstill declares the legacy GCP OpenTelemetry exporter packages (opentelemetry-exporter-gcp-logging>=1.9.0a0,<=1.12.0a0,opentelemetry-exporter-gcp-monitoring>=1.9.0a0,<2, andopentelemetry-exporter-gcp-trace>=1.9,<2) in theall,gcp, andtestoptional dependency groups. However,google.adk.telemetry.google_cloudnow exports traces, metrics, and logs to Google Cloud Telemetry (telemetry.googleapis.com) using standard OTLP HTTP exporters (opentelemetry-exporter-otlp-proto-http) andopentelemetry-resourcedetector-gcp. Keeping the unusedopentelemetry-exporter-gcp-*dependencies pulls in unnecessary packages and constrains dependency resolution (including a pre-release<=1.12.0a0upper bound onopentelemetry-exporter-gcp-logging).Solution:
Remove
opentelemetry-exporter-gcp-logging,opentelemetry-exporter-gcp-monitoring, andopentelemetry-exporter-gcp-tracefromoptional-dependencies.all,optional-dependencies.gcp, andoptional-dependencies.testinpyproject.toml, and regenerateconstraints-3.11.txtthroughconstraints-3.15.txtvia./scripts/update_constraints.sh.Testing Plan
Unit Tests:
Ran release dependency contract tests and telemetry unit tests (
pytest tests/unittests/test_release_dependencies.py tests/unittests/telemetry/):tests/unittests/test_release_dependencies.py: 20 passed (verifyingoptional-dependencies.allunion invariants and upper-bound checks)tests/unittests/telemetry/test_google_cloud.py: 40 passedtests/unittests/telemetry/: 1,021 passed, 9 xfailedManual End-to-End (E2E) Tests:
./scripts/update_constraints.sh --checkacross Python 3.11–3.15 (✅ constraints-3.{11..15}.txt is up-to-date.).pyproject-fmt --check pyproject.tomlandcodespell pyproject.toml.uv buildand verified package metadata.Checklist
Additional context
None.