[mutianf]

Summary

• _get_status unpacked protobuf error details: google.api_core.exceptions.from_grpc_error unpacks google.protobuf.any_pb2.Any messages in grpc-status-details-bin into concrete google.rpc.error_details_pb2 protobuf objects (ErrorInfo, RetryInfo, DebugInfo, etc.) in exc.details. Previously, _get_status passed details=exc.details directly to status_pb2.Status(...), raising TypeError: Parameter to initialize message field must be dict or instance of same class: expected <class 'google.protobuf.any_pb2.Any'> got ... whenever a MutateRows RPC failed with rich gRPC error details. _get_status now normalizes each item in exc.details, keeping any_pb2.Any messages and packing unpacked google.protobuf.message.Message instances into any_pb2.Any.
• MutationsBatcherAsync / MutationsBatcher error handling:
  • In _execute_mutate_rows, only compute _get_statuses_from_mutations_exception_group and Status lists when self._user_batch_completed_callback is not None (falling back to UNKNOWN statuses if an unexpected non-MutationsExceptionGroup exception occurs).
  • In MutationsBatcherAsync._wait_for_batch_results, move await task inside the try: block so unexpected task exceptions in async mode are caught and wrapped in FailedMutationEntryError rather than aborting _flush_internal before _add_exceptions (which previously caused batcher.close() to silently drop failed mutations).
• _get_error_type status code validation: core_exceptions.from_grpc_status(call_code, "") maps 0 (grpc.StatusCode.OK) and unmapped integers to the base class GoogleAPICallError, which caused retries.if_exception_type to match and retry every GoogleAPICallError subclass. _get_error_type now raises ValueError for 0 / grpc.StatusCode.OK, booleans, and any unmapped status code that falls back to base GoogleAPICallError.

Test plan

• Added unit tests in tests/unit/data/test__helpers.py for _get_status packing unpacked protobuf details and _get_error_type rejecting invalid status codes (0, grpc.StatusCode.OK, booleans, and unmapped codes).
• Added unit tests in tests/unit/data/_async/test_mutations_batcher.py (and regenerated tests/unit/data/_sync_autogen/test_mutations_batcher.py) for _execute_mutate_rows callback fallback on unexpected errors and _wait_for_batch_results catching unexpected task exceptions.
• Verified test_sync_up_to_date.py and full packages/google-cloud-bigtable/tests/unit suite pass.

[gemini-code-assist]

Code Review

This pull request optimizes the mutations batcher by deferring status list creation until a user callback is present, and wraps the async task awaiting in a try-catch block to handle unexpected exceptions. It also updates error helper functions to correctly pack unpacked error details into protobuf Any messages and validate gRPC error status codes, accompanied by comprehensive unit tests. The review feedback suggests a valuable simplification in _wait_for_batch_results to directly assign the awaited task result in async mode instead of calling task.result() redundantly.

[mutianf]

/gemini review

[gemini-code-assist]

Code Review

This pull request introduces several robustness improvements to the Bigtable mutations batcher and helper utilities. Key changes include extracting the terminal exception from a RetryExceptionGroup in the batcher, refactoring user batch completion callback execution to properly handle synchronous and asynchronous contexts, moving task awaiting inside try-except blocks to catch unexpected task exceptions, packing unpacked error details into status_pb2.Status objects, and validating gRPC error status codes in _get_error_type. Corresponding unit tests have been added to verify these behaviors. Feedback on the changes suggests defaulting exc.message to an empty string when constructing status_pb2.Status to prevent potential TypeError exceptions if the message is None.

[gemini-code-assist]

If exc.message is None, passing it directly to status_pb2.Status will raise a TypeError because protobuf string fields do not accept None. We should default it to an empty string using exc.message or "" to ensure robustness.

Suggested change

	message=exc.message,
	message=exc.message or "",