Repository navigation
Conversation
Change-Id: I6adb2982640fe2d6736ea63ed165c9ffd6feacb7
mutianf
added this pull request to stack #18691
October 20, 2026 18:07
Contributor
There was a problem hiding this comment.
Code Review
This pull request increases the inbound message size limit on the Unix Domain Socket (UDS) channel to 256 MiB for both the asynchronous and synchronous accelerator clients in the Google Cloud Bigtable library. This is achieved by defining _MAX_RECEIVE_MESSAGE_LENGTH and passing it via _CHANNEL_OPTIONS to the insecure_channel constructor, preventing potential RESOURCE_EXHAUSTED errors on local reads. There are no review comments, so I have no feedback to provide.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
gRPC caps inbound messages at 4 MiB by default — a limit sized for a channel that crosses a network. The accelerator's UDS channel doesn't leave the machine: the daemon has already paid the cost of pulling the response off the wire, and all the cap does on this hop is turn an otherwise-fine read into
RESOURCE_EXHAUSTED. This setsgrpc.max_receive_message_lengthto 256 MB so the UDS leg is never the narrower of the two.No test yet. The Go daemon still has its own 4 MiB cap on the sending side, so nothing above 4 MiB actually crosses the socket today and a test would only be asserting on a config value. The test lands once the daemon side is raised.
Only the inbound direction is changed here;
grpc.max_send_message_lengthis untouched.