Repository navigation
Require Java 17 - #923
Merged
Merged
Require Java 17#923
Conversation
Targets Java 17 for javac and Kotlin, which defaulted to 1.8. The Java tests compile on the module path again, and the Java 17 only test moves in with the other Java tests.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #810
Checklist
Description
Jackson 3 needs Java 17, so 15.0.0 drops Java 11. The Jackson 3 port comes in the PR stacked on this one.
releaseandjava.versionare 17. Kotlin now targets 17 too. It wasn't set before, so the Kotlin classes were built for 1.8 while the Java ones were 11.java17-testsprofile is gone andSchemaClassScannerSealedJavaTypesTestmoved in with the other Java tests.useModulePath=falseworkaround ondefault-testCompileis gone (its TODO was for 15.0.0). It was only needed because javac before 16 ignored module descriptors in multi-release jars. The Java tests compile on the module path again.No code changes.
mvn clean verifypasses on JDK 17 and 25 (421 tests, same as master).#881 (Kotlin's documented Maven setup) gets simpler after this and can follow.
Release note: Java 17 is the minimum.