Consul discovery: parameters are not considered

I'm adding consul discovery using dataplaneapi and found that some parameters are not considered during discovery process.
{
"name": "test-consul",
"address": "127.0.0.1",
"port": 2222,
"enabled": true,
"retry_timeout": 10,
"service_allowlist": [
"test-ext-service"
]
}
service_allowlist is not applied. Discovery process tries to add backends for ALL registered services.
The problem is here:

dataplaneapi/discovery/consul_service_discovery_instance.go

Lines 115 to 120 in b362aae

    
           case <-time.After(c.timeout): 
        
           	c.logDebug("discovery job reconciliation started") 
        
           	if err := c.updateServices(); err != nil { 
        
           		// c.log.Errorf("error while updating service: %w", err) 
        
           		c.stop() 
        
           	}

This section misses UpdateParams call:

dataplaneapi/discovery/consul_service_discovery_instance.go

Lines 101 to 108 in b362aae

    
           err := c.discoveryConfig.UpdateParams(discoveryInstanceParams{ 
        
           	Allowlist:       c.params.ServiceAllowlist, 
        
           	Denylist:        c.params.ServiceDenylist, 
        
           	LogFields:       c.logFields, 
        
           	ServerSlotsBase: int(*c.params.ServerSlotsBase), 
        
           	SlotsGrowthType: *c.params.ServerSlotsGrowthType, 
        
           	SlotsIncrement:  int(c.params.ServerSlotsGrowthIncrement), 
        
           })

Thank you for the report, it is a bug.

This should be fixed with: e50c242

Navigation Menu

Repository navigation

Consul discovery: parameters are not considered #222

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

	case <-time.After(c.timeout):
	c.logDebug("discovery job reconciliation started")
	if err := c.updateServices(); err != nil {
	// c.log.Errorf("error while updating service: %w", err)
	c.stop()
	}

	err := c.discoveryConfig.UpdateParams(discoveryInstanceParams{
	Allowlist: c.params.ServiceAllowlist,
	Denylist: c.params.ServiceDenylist,
	LogFields: c.logFields,
	ServerSlotsBase: int(*c.params.ServerSlotsBase),
	SlotsGrowthType: *c.params.ServerSlotsGrowthType,
	SlotsIncrement: int(c.params.ServerSlotsGrowthIncrement),
	})

Consul discovery: parameters are not considered #222

Description

Activity

mjuraga commented on Nov 23, 2021

mjuraga commented on Sep 29, 2022

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions