Hi #113

Activity

1. 1819981451 commented on Jul 12, 2021

   

   1819981451

   on Jul 12, 2021

   Last edited by 1819981451

   More actions

   The following code contains the reason to Go to Next difference (F7) bug and have corresponding comments
   The following code is in min/VS/Editor/editor.main.js

         class N extends c.EditorAction {
               constructor() {
                   super({
                       id: "editor.action.diffReview.next",
                       label: i.localize(10, null),
                       alias: "Go to Next Difference",
                       precondition: v.ContextKeyExpr.has("isInDiffEditor"),
                       kbOpts: {kbExpr: null, primary: 65, weight: 100}
                   })
               }
   
               run(e, t) {
                   const i = M(e);//Because M(e) return null, i = null
                   i && i.diffReviewNext()//Because i = null, i.diffreviewnext() will not be executed
               }
           }
           
           function M(e) {
               const t = e.get(h.ICodeEditorService), i = t.listDiffEditors(), n = t.getActiveCodeEditor();//n=null
               if (!n) return null;//In JavaScript ! Null is true, so M(e) also return null
               for (let e = 0, t = i.length; e < t; e++) {
                   const t = i[e]
                   ;
                   if (t.getModifiedEditor().getId() === n.getId() || t.getOriginalEditor().getId() === n.getId()) return t
               }
               return null
           }
           
            class s extends o.CodeEditorServiceImpl {
               getActiveCodeEditor() {
                   return null
               }
                   ...
               }
   
2. juaniscoding commented on Dec 1, 2023

   

   juaniscoding

   on Dec 1, 2023

   More actions

   help you with what??
3. SiweiZhong commented on Dec 1, 2023

   

   SiweiZhong

   on Dec 1, 2023 via email

   More actions

   感谢来信！已收到您的邮件！
4. huangfuyixiao commented on Dec 1, 2023

   

   huangfuyixiao

   on Dec 1, 2023 via email

   More actions

   来件已收到，我会尽快回复