Repository navigation
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
In
src/client/conn/http1.rs, themax_buf_sizebuilder docs say:There is no
read_exact_buf_sizemethod. The builder method isread_buf_exact_size(same file, declared just abovemax_buf_size). This is a word-order slip in a doc cross-reference.The reciprocal note on
read_buf_exact_sizealready points back tomax_buf_sizecorrectly, so only this one line was off.Why it matters
The wrong name misleads readers who go looking for a
read_exact_buf_sizebuilder method that does not exist.Test plan
Doc-comment-only change; no code paths touched. Verified the correct method name and the
h1_read_buf_exact_size/h1_max_buf_sizemutual-unset behavior in the same file at the currentmaster.