Repository navigation
Remove x64 exception handling code and support aarch64 - #562
Open
syntactically wants to merge 4 commits into
Open
syntactically wants to merge 4 commits into
syntactically wants to merge 4 commits into
Conversation
syntactically
force-pushed
the
lm/aarch64
branch
from
October 20, 2026 00:41
77d9f9c to
e836b62
Compare
syntactically
added this pull request to stack #563
October 20, 2026 00:42
syntactically
force-pushed
the
lm/aarch64
branch
2 times, most recently
from
October 20, 2026 00:56
f1bc9ae to
3975edd
Compare
syntactically
force-pushed
the
lm/aarch64
branch
2 times, most recently
from
October 20, 2026 17:24
5a2b052 to
a43136d
Compare
syntactically
force-pushed
the
lm/aarch64
branch
from
October 20, 2026 19:04
a43136d to
8c0eed1
Compare
This requires changing the wasi-sdk builder container definition/script a little bit to make sure it works on aarch64 as well as x86_64. Signed-off-by: Lucy Menon <168595099+syntactically@users.noreply.github.com>
Signed-off-by: Lucy Menon <168595099+syntactically@users.noreply.github.com>
As of Hyperlight 0.18.0, all of the functionality we need is supported(ish) with architecture-independent interfaces in core Hyperlight. Remove the old architecture-specific code in favour of those new interfaces. Signed-off-by: Lucy Menon <168595099+syntactically@users.noreply.github.com>
syntactically
force-pushed
the
lm/aarch64
branch
from
October 20, 2026 19:08
8c0eed1 to
f3e17b7
Compare
jsturtevant
reviewed
Oct 20, 2026
| len: usize, | ||
| ) -> i32 { | ||
| copy_va_mapping(image as *mut u8, len, addr, false); | ||
| copy_va_mapping(image as *mut u8, len, addr, false, true); |
Contributor
There was a problem hiding this comment.
I think it is right that this flipped due to the barrier tracker? Just calling out since it is flipped here
jsturtevant
reviewed
Oct 20, 2026
| ptr: *const u8, | ||
| len: usize, | ||
| ) -> core::result::Result<(), wasmtime::Error> { | ||
| wasmtime_mprotect( |
Contributor
There was a problem hiding this comment.
nice, to see this get used!
Signed-off-by: Lucy Menon <168595099+syntactically@users.noreply.github.com>
syntactically
force-pushed
the
lm/aarch64
branch
from
October 20, 2026 22:16
f3e17b7 to
8c7a8fe
Compare
jsturtevant
reviewed
Oct 20, 2026
| spin::Mutex::new(None); | ||
|
|
||
| extern "C" fn page_fault_handler(pc: u64, fp: u64, va: u64) -> ! { | ||
| if let Some(requested_handler) = *WASMTIME_REQUESTED_TRAP_HANDLER.lock() { |
Contributor
There was a problem hiding this comment.
does this mutex leak on the second call after the trap handler runs?
jsturtevant
reviewed
Oct 20, 2026
| name: guest-modules-${{ matrix.wasmtime_version.name }} | ||
| name: guest-modules-${{ matrix.arch }}-${{ matrix.wasmtime_version.name }} | ||
| path: | | ||
| x64/release/*.aot |
Contributor
There was a problem hiding this comment.
nit: maybe this should be by arch too?
jsturtevant
reviewed
Oct 20, 2026
| // sets the Rust target to be compiled with the hard-float ABI manually via | ||
| // `-Zbuild-std` and a custom target JSON configuration | ||
| // See https://github.com/bytecodealliance/wasmtime/pull/11553 | ||
| #[cfg(all(not(feature = "wasmtime_lts"), not(pulley)))] |
Contributor
There was a problem hiding this comment.
we might need to fix this up for arm too? are we going to have any float issues for ARM (I guess ci tests would catch it?)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.