Skip to content

fix(menu): allow menus inside split pane main content to open - #31586

Merged
ShaneK merged 1 commit into
mainfrom
FW-7868
Oct 21, 2026
Merged

ShaneK merged 1 commit into
mainfrom
FW-7868

Conversation

@ShaneK

@ShaneK ShaneK commented Oct 16, 2026

Copy link
Copy Markdown
Member

Issue number: resolves #30591


What is the current behavior?

Currently, a menu inside the split pane's main content, like an end menu on a page, is treated as a side pane, so it can't be opened while the split pane is visible. This broke in 8.0 when #28801 changed the menu to look for any ancestor split pane, so that wrapped menus would work.

What is the new behavior?

A menu in the main content is now a regular menu and opens normally. Wrapped side menus still work, since the menu doesn't need to be a direct child of the split pane.

Does this introduce a breaking change?

  • Yes
  • No

Other information

@ShaneK
ShaneK requested a review from a team as a code owner October 16, 2026 20:57
@ShaneK
ShaneK requested a review from brandyscarney October 16, 2026 20:57
@vercel

vercel Bot commented Oct 16, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
ionic-framework Ready Ready Preview Oct 16, 2026 8:58pm UTC

Request Review

@OS-jacobbell OS-jacobbell left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ShaneK
ShaneK added this pull request to the merge queue Oct 21, 2026
Merged via the queue into main with commit 3eebee3 Oct 21, 2026
56 checks passed
@ShaneK
ShaneK deleted the FW-7868 branch October 21, 2026 21:07

This branch was successfully deployed

1 active deployment
Preview — cfa52f4b Deployed Oct 16, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

package: core @ionic/core package

Projects

None yet

Development

Successfully merging this pull request may close these issues.

bug: v7 => v8 Ion-split-pane + another ion-menu doesn’t work anymore

2 participants