Skip to content

refactor(gallery-item): migrate to modular theming - #31606

Open
brandyscarney wants to merge 1 commit into
ionic-modularfrom
FW-7286-gallery-item
Open

brandyscarney wants to merge 1 commit into
ionic-modularfrom
FW-7286-gallery-item

Conversation

@brandyscarney

@brandyscarney brandyscarney commented Oct 19, 2026 •

Copy link
Copy Markdown
Member

Issue number: internal


What is the current behavior?

ion-gallery-item reads the theme and adds it as a class on its host, but none of its styles depend on the theme.

What is the new behavior?

  • Migrates ion-gallery-item to Modular Ionic: removes the theme virtual prop and the theme class on the host.
  • The stylesheet has no per-theme files and no theme-dependent values, so it adds no recipe, config or tokens.
  • Regenerates api.txt, components.d.ts and the Angular proxies, which drop the theme input.

Does this introduce a breaking change?

  • Yes
  • No

ion-gallery-item hasn't been in a release yet, so removing theme isn't breaking.

Other information

How to test

Check Before After What to look for
Basic ionic-modular this PR A grid of colored square tiles. Tiles, gaps and corners should match.
Layouts ionic-modular this PR Uniform items stay square; masonry items stack with even gaps and no gap under the last item in each column.
Wrapper ionic-modular this PR Items wrapped in <figure> line up with the others and keep the same size.

Swap ionic:theme and ionic:mode to ios or md to check the other themes.

@github-actions github-actions Bot added package: core @ionic/core package package: angular @ionic/angular package labels Oct 19, 2026
@vercel

vercel Bot commented Oct 19, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
ionic-framework Ready Ready Preview Oct 19, 2026 10:23pm UTC

Request Review

@brandyscarney
brandyscarney added this pull request to stack #31613 October 20, 2026 19:28
@brandyscarney
brandyscarney marked this pull request as ready for review October 20, 2026 19:50
@brandyscarney
brandyscarney requested a review from a team as a code owner October 20, 2026 19:50
@brandyscarney
brandyscarney requested a review from ShaneK October 20, 2026 19:50

This branch was successfully deployed

1 active deployment
Preview — 5031658d Deployed Oct 19, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

package: angular @ionic/angular package package: core @ionic/core package

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant