Repository navigation
Conversation
Include the visible month and year before the month/year toggle's existing Show/Hide year picker instruction. The action-only aria-label overrides the visible date and violates WCAG 2.5.3 (Label in Name), preventing voice-control users from targeting the button by its text. Reuse the localized month/year string for both the visible text and accessible name so they stay in sync as the calendar, value, locale, and picker state change, without adding a new API. Extend the existing spec tests to assert the complete collapsed and expanded labels, and cover updates to the localized month/year. Fixes ionic-team#31608
|
@ljanner is attempting to deploy a commit to the Ionic Team on Vercel. A member of the Team first needs to authorize it. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue number: resolves #31608
Include the visible month and year before the month/year toggle's existing Show/Hide year picker instruction. The action-only aria-label overrides the visible date and violates WCAG 2.5.3 (Label in Name), preventing voice-control users from targeting the button by its text.
Reuse the localized month/year string for both the visible text and accessible name so they stay in sync as the calendar, value, locale, and picker state change, without adding a new API.
Extend the existing spec tests to assert the complete collapsed and expanded labels, and cover updates to the localized month/year.
Does this introduce a breaking change?