Skip to content

test(scripts): pick the testing font by theme instead of mode - #31618

Open
thetaPC wants to merge 1 commit into
ionic-modularfrom
FW-7883
Open

thetaPC wants to merge 1 commit into
ionic-modularfrom
FW-7883

Conversation

@thetaPC

@thetaPC thetaPC commented Oct 20, 2026

Copy link
Copy Markdown
Contributor

Issue number: resolves internal


What is the current behavior?

Test pages pick their testing font from the <html> classes. On ionic-modular, <html> has both the mode and theme classes, so an md theme page in ios mode gets the iOS testing font instead of the md one.

What is the new behavior?

  • The testing styles follow the theme attribute Ionic sets on <html> for all three themes, instead of the mode and theme classes, so each theme gets its own font in either mode.
  • Only test pages load this file, and every configs() combination already pairs a theme with its own font, so no screenshots change.

Does this introduce a breaking change?

  • Yes
  • No

Other information

Found in the title animations PR review (#31559). Tracked in FW-7883.

How to test

Check Before After What to look for
md theme, ios mode before after The titles use Roboto in the after link, like the md theme in md mode, instead of the iOS system font

@vercel

vercel Bot commented Oct 20, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
ionic-framework Ready Ready Preview Oct 20, 2026 11:16pm UTC

Request Review

@github-actions github-actions Bot added the package: core @ionic/core package label Oct 20, 2026
@thetaPC
thetaPC marked this pull request as ready for review October 20, 2026 23:41
@thetaPC
thetaPC requested a review from a team as a code owner October 20, 2026 23:41
@thetaPC
thetaPC requested a review from brandyscarney October 20, 2026 23:41

This branch was successfully deployed

1 active deployment
Preview — 20d88d04 Deployed Oct 20, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

package: core @ionic/core package

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant