Repository navigation
Finish Strict Typing - #885
Merged
Merged
Conversation
added 2 commits
October 28, 2023 09:53
added 2 commits
October 28, 2023 11:34
blink1073
force-pushed
the
now-even-more-types
branch
from
October 28, 2023 16:36
ee4ee88 to
8fbc26e
Compare
blink1073
enabled auto-merge (squash)
October 28, 2023 19:20
cursor Bot
pushed a commit
to apoorvdarshan/traitlets
that referenced
this pull request
Sep 22, 2026
Container.from_string substituted None for a value that failed literal_eval, then passed it to validate. Since PR ipython#885 added an allow_none short-circuit to Instance.validate, that None is now accepted for allow_none containers instead of raising, so a single --Class.trait=value (e.g. List(allow_none=True)) resolves to None instead of ['value']. Validate the original string on parse failure instead of None. A bare string is not a container, so validation raises as it did before ipython#885, letting DeferredConfig.get_value fall back to collating the value into a single-item list. Fixes ipython#908
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.