Skip to content

Nest link annotation and underline within Link - #9

Closed
rjcohn wants to merge 8 commits into
itext:developfrom
rjcohn:feature/fix-tag-underline
Closed

rjcohn wants to merge 8 commits into
itext:developfrom
rjcohn:feature/fix-tag-underline

Conversation

@rjcohn

@rjcohn rjcohn commented Jan 16, 2017

Copy link
Copy Markdown
Contributor

Fix two separate problems:

  • Matterhorn 28-011: A link annotation is not nested within a Link tag.
  • Matterhorn 13-001: Graphics should be tagged (the condition says
    figure, but in this case it should be within the Link).
    See also: https://www.w3.org/TR/WCAG20-TECHS/PDF11.html
    Example 4: Marking up link text using a /Link structure element

The first problem is fixed by creating the Link in the structure
tree before creating the element for the annotation. The second is
fixed by closing the marked content after drawing the underline.

pavel-morozov-duallab and others added 8 commits January 16, 2017 11:45
…stractElement.getProperty.") in order to facilitate autoporting and avoid breaking of backward compatibility; also fix minor bug

In my opinion the best way to implement this would be to use an ArrayList and backward iterate it with a simple for-loop, however this would still break backward compatibility.
This test shows 2 problems:
- Matterhorn 28-011: A link annotation is not nested within a Link tag.
- Matterhorn 13-001: Graphics should be tagged (the condition says
  figure, but in this case it should be within the Link).
  See also:  https://www.w3.org/TR/WCAG20-TECHS/PDF11.html
    Example 4: Marking up link text using a /Link structure element
Fix two separate problems:
- Matterhorn 28-011: A link annotation is not nested within a Link tag.
- Matterhorn 13-001: Graphics should be tagged (the condition says
  figure, but in this case it should be within the Link).
  See also:  https://www.w3.org/TR/WCAG20-TECHS/PDF11.html
    Example 4: Marking up link text using a /Link structure element

The first problem is fixed by creating the Link in the structure
tree before creating the element for the annotation. The second is
fixed by closing the marked content after drawing the underline.
@blagae

blagae commented Jan 25, 2017

Copy link
Copy Markdown
Contributor

Hi @rjcohn,

This pull request has been rebased on top of the current develop branch. Thanks for your work !

Benoit

@blagae blagae closed this Jan 25, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants