Repository navigation
pac4j: preserve absolute URLs in URL resolver - #4020
Open
2748109647 wants to merge 1 commit into
Open
2748109647 wants to merge 1 commit into
2748109647 wants to merge 1 commit into
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4020 +/- ##
============================================
- Coverage 94.18% 94.16% -0.03%
+ Complexity 6653 6652 -1
============================================
Files 432 432
Lines 20893 20894 +1
Branches 2096 2096
============================================
- Hits 19678 19674 -4
- Misses 757 764 +7
+ Partials 458 456 -2 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #4010
UrlResolverImplis used for callback and authentication-server URLs. With a request context, it currently treats every absolute URL as an application path, replacing its authority and dropping its query string. For CAS, this sends the login redirect back to the application instead of the CAS server.Return absolute URLs unchanged and keep context-based resolution for relative URLs. This preserves configured absolute callback and external login URLs while retaining trusted-proxy-aware resolution for relative callback paths. It also keeps absolute callback URLs valid for the case fixed by #3637.
Verification
UrlResolverImplTest: 2 tests passed with Maven 3.9.9 and JDK 21.git diff --check: passed.jooby-storkentry was temporarily omitted frommodules/pom.xmlbecause this local root-reactor scan reportedUnknown packaging: tile; no build-file change is included in this PR.