Repository navigation
Conversation
keichi
force-pushed
the
fix-bit-assert-scope
branch
from
October 18, 2026 13:55
790c132 to
69a321f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Bit fields are deferred until the whole bit group is read. When the group spans into a
nest(whose first field is a bit field), the deferred fields are flushed inside the nest's scope.generateAssertandgenerateFormatterresolved the variable path /thiswithctx.generateVariable()at flush time, so they referenced the nested scope instead of the field's own scope.Repro
A formatter on
xwould likewise be called withthisbound tovars.ninstead ofvars.Fix
generateAsserttakes an optional pre-resolvedvarNameandgenerateFormatteran optionalthisVar.generateBitcaptures both at deferral time and passes them when flushing. Added a regression test.