Repository navigation
fix(middleware): reject CSRF TokenLookup that produces no extractors (v4) - #3149
Merged
Merged
Conversation
…in v4 A TokenLookup whose sources are all unknown (for example "nope:nope") parsed without error but yielded zero extractors. With nothing to check, unsafe requests were let through without any token validation. Fail middleware creation instead, so the misconfiguration surfaces at startup. Backport of labstack#3067.
vishr
approved these changes
Oct 22, 2026
vishr
left a comment
Member
There was a problem hiding this comment.
Reviewed as a minimal v4 backport of the existing v5 startup validation. A TokenLookup with no recognized extractors must fail configuration instead of silently skipping token validation. This fits the v4 bug-fix-only policy.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #3067 to v4.
If every source in
TokenLookupis unknown (for examplenope:nope),CreateExtractorsreturns an empty list without an error. The middleware is then created with nothing to check, so unsafe requests go through with no token validation.ToMiddlewarenow returns an error in that case, so the misconfiguration shows up at startup instead of silently turning CSRF protection off.Added a case to
TestCSRF_tokenExtractors. It fails before the change and passes after.go test ./...passes.