Repository navigation
fix(notes): preserve selected note for ambiguous internal links - #957
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Selecting a note in the internal-link picker could open a same-named code snippet because the inserted title-only link resolves to snippets first.
Use a typed note ID with a readable label when a note name collides with another entity type, including case-insensitive matches. Keep ordinary title and folder-path links for other selections.
Validation: 106 scoped tests passed; staged-file formatting and ESLint passed. UI QA confirmed distinct note/snippet targets and persistence after reopening and renderer reload. Native Cmd-click navigation was not exercised because the UI automation tool lacks modifier-click support; navigation handlers are covered by tests.
Closes #947