Repository navigation
fix(notes): resolve default vault identity for image paste and related actions - #975
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #972
Problem
storage.vaultPathdefaults tonull. The renderer sendspref ?? ''as the vault token, and the main process compared that token with the resolvedgetVaultPath(). For users on the default vault these values never match, so every request was rejected as stale. Since v6.0.0, image paste and drop in notes has silently failed, along with several other actions guarded the same way. This affects all platforms, not only Windows.Fix
vaultIdentity()inruntime/paths.tsreturns the raw preference token (storage.vaultPath ?? ''). All stale checks between renderer and main now compare against this token.getVaultPath()is used only for filesystem paths and HTTP session keys.?? ''so they match the token main uses.Affected flows
Tests
Added regression cases for the default vault (
nullpreference) to each touched test suite.