Repository navigation
fix(storage): write vault files atomically to avoid truncation on failure - #985
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Notes, snippets, HTTP requests, folder
.meta.yaml,state.json/.state.yamland doctor id fixes were written withfs.writeFileSyncover the existing file. It truncates first, so ENOSPC/EIO in the middle of a write left a cut-off file on disk even though the runtime rolled back.writeFileAtomicSyncinruntime/shared/atomicWrite.ts: write a hidden.<name>.<hex>.tmpnext to the target, thenrenameSyncover it. Preserves the file mode, writes through symlinks, removes the temp file on failure, falls back to an in-place write on Windows when the target is locked by another process.renameSync.Checked on a real iCloud Drive vault with the dev build: repeated saves, rename/move, external edits picked up by the watcher, upload without conflicts, content verified after eviction, edits blocked until a dataless note is downloaded.