Repository navigation
Add composition events to GlobalEventHandlers - #949
Merged
Merged
Conversation
Marijn Haverbeke (marijnh)
requested a review
from Nathan Shively-Sanders (sandersn)
as a code owner
November 4, 2020 12:48
| "type": "Event" | ||
| }, | ||
| { | ||
| "name": "compositionstart", |
Contributor
There was a problem hiding this comment.
Since there is no corresponding oncompositionstart etc., these should go to attributeless-events instead. Also, please run npm i && npm run build && npm run baseline-accept and commit the results.
Contributor
Author
There was a problem hiding this comment.
Thanks for the pointer! I've updated the patch.
Contributor
Author
|
Is there anything else I can do to move this forward? |
Contributor
|
Looks very available to me: https://caniuse.com/mdn-api_element_compositionstart_event - thanks |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
GlobalEventHandlerswere missing"compositionstart","compositionupdate"and"compositionend", which caused errors when trying to use a function type that relied on getting even object types from that type.(I should note that I don't really know what I'm doing here, and just searched for the other event names and added similar declarations in what looked like the appropriate place.)