This repository was archived by the owner on Oct 12, 2022. It is now read-only.
Repository navigation
This repository was archived by the owner on Oct 12, 2022. It is now read-only.
Reference to jquery remains in the jsx sample. Sample not working #157
Description
The references to jquery were removed in commit e190f5a.
A reference to jquery still remains in app.tsx and in require-config.js
app.tsx $ remains
ReactDOM.render(<Greetifier {...props} greeting={getRandomGreeting} />, $('#output').get(0));
configure-js
"jquery": ['/node_modules/jquery/dist/jquery']
I tried replacing $('#output') with document.getElementById('#output') but got an error "Target container is not a DOM element." I don't know where to go from here.
Activity
mikevbaker commentedon Aug 28, 2019
I figured it out. I forgot to remove the # from the id. The correct line would be this...
ReactDOM.render(<Greetifier {...props} greeting={getRandomGreeting} />, document.getElementById('output'));
mikevbaker commentedon Aug 28, 2019
I have changes done locally and will create PR whenever it's marked 'help wanted'.