Repository navigation
fix: record sessions to bare relative filenames - #8347
Open
Aditya Pratap Singh (akkupratap323) wants to merge 1 commit into
Open
Aditya Pratap Singh (akkupratap323) wants to merge 1 commit into
Aditya Pratap Singh (akkupratap323) wants to merge 1 commit into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
Recording a session to
session.jsonraisesValueErrorbecausefinalize()tries to create an empty parent directory. Create a directory only when the session path has a parent, so a bare filename saves into the working directory.The regression records and replays a real interaction with the offline replay client, covering bare filenames,
./paths, missing nested directories and absolute paths. The bare-filename case fails on the original source while the other three pass; all four pass with this change.Related issue number
Fixes #8346
Checks
The full extension suite and live-provider integration tests were not run. #7797's encoding change is separate; this patch leaves file encoding unchanged. Investigated and implemented with Codex assistance; tests ran locally against the real classes.