Repository navigation
Update to latest lsp for pull diagnostics - #23979
Merged
Rich Chiodo (rchiodo) merged 19 commits intoAug 23, 2024
Merged
Conversation
Rich Chiodo (rchiodo)
requested review from
Erik De Bonte (debonte) and
Karthik Nadig (karthiknadig)
August 20, 2024 23:17
Author
|
Uggh i forgot about all the tsconfig.json changes necessary for this. This might take me a bit longer. |
| "tsconfig-paths-webpack-plugin": "^3.2.0", | ||
| "typemoq": "^2.1.0", | ||
| "typescript": "4.5.5", | ||
| "typescript": "~5.2", |
There was a problem hiding this comment.
Because of the new way Dirk is exporting the api from the LSP client, I had to update the typescript compiler and the tsconfig.json. It's basically what caused all of these changes.
| } | ||
|
|
||
| export function untildify(path: string): string { | ||
| return path.replace(/^~($|\/|\\)/, `${os.homedir()}$1`); |
There was a problem hiding this comment.
Untilidify doesn't work so well with new typescript. Just asked copilot to generate a new one.
Author
|
Karthik Nadig (@karthiknadig) Erik De Bonte (@debonte) this looks like it finally works. The root of all of these changes in the LSP client requiring a newer typescript. That rippled through a lot of dependencies. |
…o/vscode-python into rchiodo/update_latest_lsp
Erik De Bonte (debonte)
approved these changes
Aug 23, 2024
Karthik Nadig (karthiknadig)
approved these changes
Aug 23, 2024
Anthony Kim (anthonykim1)
pushed a commit
to anthonykim1/vscode-python
that referenced
this pull request
Sep 13, 2024
This is to match the latest updates we've made in pylance. See this PR: microsoft/pyrx#5590
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is to match the latest updates we've made in pylance.
See this PR:
https://github.com/microsoft/pyrx/pull/5590