Repository navigation
switch to using temp file for test_ids - #24054
Merged
Merged
Conversation
Eleanor Boyd (eleanorjboyd)
marked this pull request as ready for review
September 4, 2024 22:42
Eleanor Boyd (eleanorjboyd)
requested a review
from Karthik Nadig (karthiknadig)
September 4, 2024 22:42
Karthik Nadig (karthiknadig)
requested changes
Sep 4, 2024
| } catch (error) { | ||
| // Handle the error when accessing the temp directory | ||
| traceError('Error accessing temp directory:', error, ' Attempt to use extension root dir instead'); | ||
| tempFileName = path.join(EXTENSION_ROOT_DIR, '.temp', tempName); |
There was a problem hiding this comment.
Do you need to explicitly create the directory or does it automatically create on writeFile?
Author
There was a problem hiding this comment.
ideas on how to test this manually or with a test case? Seems like I can't mock tmpdir to include it in a test
There was a problem hiding this comment.
I will show you a trick for a future PR
Co-authored-by: Karthik Nadig <kanadig@microsoft.com>
Eleanor Boyd (eleanorjboyd)
requested a review
from Karthik Nadig (karthiknadig)
September 5, 2024 18:21
Karthik Nadig (karthiknadig)
approved these changes
Sep 5, 2024
Anthony Kim (anthonykim1)
pushed a commit
to anthonykim1/vscode-python
that referenced
this pull request
Sep 13, 2024
first step in work on microsoft#23279 --------- Co-authored-by: Karthik Nadig <kanadig@microsoft.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
first step in work on #23279