OneDrive path based addressing #40

Activity

1. Philip Gichuhi (Ndiritu)

   self-assigned this

   on Jan 12, 2023
2. Ndiritu commented on Jan 12, 2023

   

   Philip Gichuhi (Ndiritu)

   on Jan 12, 2023

   Contributor

   More actions

   James Haggerty (@wryun) to minimize SDK size, this version of the SDK provides access to resources via the root path of the resource in cases where there are multiple URLs to perform the same operation e.g. an upload session can be created via multiple endpoints but the SDK supports accessing the root of the resource i.e. /drives/{driveId}/items/{itemId}/createUploadSession

   You should be able to create the upload session via:

   await client.drives_by_id('driveId').items_by_id('root:/{item-path}:').create_upload_session().post()
3. Ndiritu commented on Jan 12, 2023

   

   Philip Gichuhi (Ndiritu)

   on Jan 12, 2023

   Last edited by Ndiritu

   Contributor

   More actions

   Shem Ogumbe (@shemogumbe) Vincent Biret (@baywet) Isaac Vargas (@isvargasmsft) should we add a disclaimer on the READMEs that not all API paths will be supported by the request builders & what fallback options we will provide if any? We had a similar issue in PHP.
4. baywet commented on Jan 12, 2023

   

   Vincent Biret (baywet)

   on Jan 12, 2023

   Member

   More actions

   Thanks for flagging this. The workarounds for those sort of situations are:

   • issue two requests, one to get the id, and then another one on the canonical path with the id.
   • instantiate a request builder, pass an already built URLs

   none are great from a user experience perspective.

   👍React with 👍1Reacted by Philip Gichuhi
5. Ndiritu commented on Jan 13, 2023

   

   Philip Gichuhi (Ndiritu)

   on Jan 13, 2023

   Last edited by Ndiritu

   Contributor

   More actions

   Do we currently support workaround 2?
6. baywet commented on Jan 13, 2023

   

   Vincent Biret (baywet)

   on Jan 13, 2023

   Member

   More actions

   We should for that scenario specifically.
   The way it's done in dotnet and Go is we have overload constructors that either accept the path parameters (fluent API passing things along) or the raw URL for this purpose.
   https://github.com/microsoftgraph/msgraph-sdk-go/blob/767c30e984b3fec03e6e5ca11b4c68c6db935249/admin/admin_request_builder.go#L43
   https://github.com/microsoftgraph/msgraph-sdk-go/blob/767c30e984b3fec03e6e5ca11b4c68c6db935249/admin/admin_request_builder.go#L56

   👍React with 👍1Reacted by Philip Gichuhi
7. isvargasmsft commented on Jan 24, 2023

   

   Isaac Vargas (isvargasmsft)

   on Jan 24, 2023

   Member

   More actions

   Shem Ogumbe (@shemogumbe) Vincent Biret (@baywet) Isaac Vargas (@isvargasmsft) should we add a disclaimer on the READMEs that not all API paths will be supported by the request builders & what fallback options we will provide if any? We had a similar issue in PHP.

   Samwel K. (@samwelkanda) for visibility.
8. samwelkanda commented on Nov 2, 2023

   

   Samwel K. (samwelkanda)

   on Nov 2, 2023

   Last edited by samwelkanda

   Contributor

   More actions

   Going with the convention of accessing resources from their root, the above can be done by issuing the request:

   async def create_upload_session():   
    resp = await client.drives.by_drive_id('driveId').items.by_drive_item_id('root:/{item-path}:').create_upload_session().post()
   asyncio.run(create_upload_session())
9. samwelkanda commented on Nov 2, 2023

   

   Samwel K. (samwelkanda)

   on Nov 2, 2023

   Contributor

   More actions

   Closing as not a blocking issue.
10. Samwel K. (samwelkanda)

    closed this as completedon Nov 2, 2023