Repository navigation
fix(ci): check public text against a private denylist (ENG-3469) - #72
Draft
lucas-koontz wants to merge 1 commit into
Draft
lucas-koontz wants to merge 1 commit into
lucas-koontz wants to merge 1 commit into
Conversation
Refs: ENG-3469
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
User story
As a contributor to a public repository, I want restricted public text checked automatically so accidental disclosures are caught before merge and after text edits.
Why this matters
Copied ticket text can expose restricted names or private dependencies in PR descriptions, branches, commits and comments. This adds a shared scanner with separate PR and text-audit callers. The check runs after publication and does not erase earlier revisions.
Acceptance criteria
How to test
Run
uv run --with pyyaml --with pytest --python 3.12 -m pytest tests/ -q,actionlint, the workflow graph check and the advisory security audit. After merge and operator configuration, followdocs/public-text.mdusing only its synthetic canary. Verify description edits, audit reruns, missing-secret failure and the fork exception.Notes for the reviewer
@mainreusable until merge. Existing CI and local verification support bootstrap review; do not require the new context yet. Notifications and event delivery have documented limitations.Verified locally
Ships with
Callers in mindsdb/anton, mindsdb/cowork-server and mindsdb/cowork are prepared separately.
Merge order: this PR first, then the application callers. Promote callers to their default branches before expecting issue/comment coverage. Operator configuration and live canary checks complete activation. No application deployment is part of this PR.