Skip to content

ExtensionTypeCustomDeserializers's addTargetClass() and addTargetTypeReference() wrongly expect data filed in ext type value is MessagePack format #536

Closed
#539
Closed
ExtensionTypeCustomDeserializers's addTargetClass() and addTargetTypeReference() wrongly expect data filed in ext type value is MessagePack format#536
#539
Assignees
komamitsu

Description

@komamitsu
komamitsu
opened on Dec 12, 2020

The 2 methods wrongly expect data field in ext type value is MessagePack format, but the format of ext type data field (https://github.com/msgpack/msgpack/blob/master/spec.md#ext-format-family) isn't supposed to be MessagePack. So the 2 methods should be removed.

Activity

  1. komamitsu
    self-assigned this
    on Dec 12, 2020
  2. komamitsu
    closed this as completedin #539on Dec 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

No labels
No labels

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions