Skip to content

refactor: migrate to ESM - #542

Merged
Trott merged 1 commit into
nodejs:mainfrom
targos:esm
Jul 30, 2024
Merged

Trott merged 1 commit into
nodejs:mainfrom
targos:esm

Conversation

@targos

@targos targos commented Jul 22, 2024

Copy link
Copy Markdown
Member

No description provided.

@targos
targos requested a review from a team as a code owner July 22, 2024 21:43
@Trott

Trott commented Jul 22, 2024

Copy link
Copy Markdown
Member

LGTM. Is there a case to be made for landing #541 first, since it's a smaller/more focused change?

@targos

targos commented Jul 28, 2024

Copy link
Copy Markdown
Member Author

LGTM. Is there a case to be made for landing #541 first, since it's a smaller/more focused change?

That PR is only useful if we don't migrate to ESM, so I think not (unfortunately). But feel free to merge it if you'd like to acknowledge the contribution and I'll add a revert commit to this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants