Skip to content

NODE_API_SWALLOW_UNTHROWABLE_EXCEPTIONS only catch one throw  #1027

Closed
Closed
NODE_API_SWALLOW_UNTHROWABLE_EXCEPTIONS only catch one throw #1027

Description

@JsBlueCat
JsBlueCat
opened on Jul 24, 2021

use NODE_API_SWALLOW_UNTHROWABLE_EXCEPTIONS in defines will solve one throw problem.

but if do another throw, the node-addon-api will be crashed

Activity

  1. KevinEady commented on Aug 13, 2021

    @KevinEady
    KevinEady
    on Aug 13, 2021
    Contributor

    Hello,

    We took a look at this in today's Node.js API meeting, and just and FYI this change was introduced via #975

  2. github-actions commented on Nov 12, 2021

    @github-actions
    github-actionsBot
    on Nov 12, 2021
    Contributor

    This issue is stale because it has been open many days with no activity. It will be closed soon unless the stale label is removed or a comment is made.

  3. github-actions
    added
    stale
    on Nov 12, 2021
  4. KevinEady
    removed
    stale
    on Nov 13, 2021

  5. gabrielschulhof commented on Nov 19, 2021

    @gabrielschulhof
    gabrielschulhof
    on Nov 19, 2021
    Contributor

    @JsBlueCat can you please try release 4.0.0 or later of node-addon-api and tell us whether you still see this issue and re-open it if you do?

  6. gabrielschulhof
    closed this as completedon Nov 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions