Repository navigation
Is it safe to use Napi::Addon and Napi::ObjectWrap together? #1097
Description
I have an addon which contains most methods on class inherited from Napi::Addon, and i have another class (SimpleObject in this example) whose lifetime needs to be bound to JS code. Is it safe to use it like in the example below, or there is a better alternative? Thx.
Example (simplified):
class SimpleObject : public Napi::ObjectWrap<SimpleObject> {
static Napi::Object Init(Napi::Env env, Napi::Object exports) {
std::string class_name = "SimpleObject";
Napi::Function constructor = DefineClass(env, class_name.c_str(), {
InstanceMethod("getValue", &SimpleObject::GetValue),
});
auto* constructor_ref = new Napi::FunctionReference();
*constructor_ref = Napi::Persistent(constructor);
exports.Set(class_name, constructor);
env.SetInstanceData(constructor_ref);
return exports;
}
};
class SimpleAddon : public Napi::Addon<SimpleAddon> {
public:
SimpleAddon(Napi::Env env, Napi::Object exports) {
SimpleObject::Init(env, exports); // init SimpleObject here as well
DefineAddon(exports, {
InstanceMethod("someMethod", &SimpleAddon::SomeMethod),
});
}
};
NODE_API_ADDON(SimpleAddon)
Activity
gabrielschulhof commentedon Nov 5, 2021
@Patick-Bateman
Napi::Addonusesenv.SetInstanceData()internally, so setting the constructor as the instance data will overwriteNapi::Addon's data. You will want to store the persistent reference to the constructor as an instance variable of yourSimpleAddonclass:doc: add blurb about SetInstanceData
doc: add blurb about SetInstanceData
doc: add blurb about SetInstanceData
doc: add blurb about SetInstanceData
doc: add blurb about SetInstanceData