Skip to content

Missing Napi::Value::IsBigInt method #1299

Closed

Description

Hi, I see Napi::Value has methods to determine the type of its underlying value, such as IsNumber, IsObject, etc. However, there's no such method for Napi::BigInt, which is a subclass of Napi::Value, at least according to https://github.com/nodejs/node-addon-api/blob/v6.0.0/doc/value.md

This needs to be corrected ASAP.

Activity

  1. mhdawson commented on Mar 28, 2023

    @mhdawson
    Member

    I'm not sure what version of node-api you are using but it exists for NAPI_VERSION 5 and greater. See

    #if NAPI_VERSION > 5

  2. mhdawson commented on Mar 28, 2023

    @mhdawson
    Member

    @martingalvan-nordic probably just an oversight, PRs welcome

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions